Skip to content

Added tests for wp_timezone_choice #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pbearne wants to merge 28 commits into
base: trunk
Choose a base branch
from
Open

Added tests for wp_timezone_choice #5694

pbearne wants to merge 28 commits into from

Conversation

@pbearne
Copy link

@pbearne pbearne commented Nov 21, 2023

@github-actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, sirlouen, wildworks, westonruter, audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Feb 28, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@pbearne
Remove redundant city translations in ES locale
80e7ac8 
The redundant city translations in Spanish locale have been removed to clean up the codebase. PHPUnit tests have been updated to adapt to these changes. This removal involves hundreds of city translations that were unused, improving the readability and maintainability of the translation file.
@pbearne
Merge remote-tracking branch 'origin/59941-wp_timezone_choice' into 5…
0b01da3 
…9941-wp_timezone_choice
@pbearne
Update Spanish locale message translations
2201680 
This commit updates the Spanish locale translations by adding new city translations in the continents-cities-es_ES.po and improving the error and menu translations in es_ES.po. The corresponding l10n.php and .mo files have also been updated to reflect these changes. These updates aim to enhance the localization of the application for Spanish language users.
audrasjb
audrasjb requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good to me. I added a few nitpick comments :)

SirLouen
SirLouen suggested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@SirLouen SirLouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last check before 6.9

westonruter
westonruter requested changes Nov 3, 2025
View reviewed changes
SirLouen
SirLouen suggested changes Nov 5, 2025
View reviewed changes
Copy link
Member

@SirLouen SirLouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's looking good to me.
I've sent you a PR with some final little CS tweaks.

westonruter
westonruter requested changes Nov 6, 2025
View reviewed changes
@SirLouen
Copy link
Member

SirLouen commented Nov 6, 2025

@pbearne did you see my PR?

westonruter
westonruter approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, at least the code in tests/functions. For the changes in data/languages, I have no experience. So I defer to someone who has.

@westonruter
Copy link
Member

westonruter commented Nov 7, 2025

did you see my PR?

@SirLouen Can you apply your suggestions directly to this PR? Or can you provide a link to the PR you're referring to?

@SirLouen
Copy link
Member

SirLouen commented Nov 24, 2025

@westonruter it was only some little tweaks I sent back in the day to @pbearne 's branch
pbearne#183

@westonruter
Merge branch 'trunk' into 59941-wp_timezone_choice
828c8af
@westonruter
Merge #183
db4e98a 
Merge branch 'patch/59941' into 59941-wp_timezone_choice

* patch/59941:
  fix: correct class name casing and improve docblock formatting in timezone choice tests
@westonruter
Copy link
Member

westonruter commented Nov 24, 2025

@SirLouen I fixed the merge conflicts and merged the branch into this one.

SirLouen
SirLouen approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@SirLouen SirLouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirLouen I fixed the merge conflicts and merged the branch into this one.

Great, do you think it's ready for commit?
There have been some minor tweaks lately that I hope I have not skipped, but it's looking good to me.

@westonruter
Copy link
Member

westonruter commented Nov 24, 2025

As far as I can see, yes, it looks ready for commit. But I don't have any experience with adding files to ‎tests/phpunit/data so I defer to someone with i18n expertise, especially @swissspidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@audrasjb audrasjb Awaiting requested review from audrasjb

@swissspidy swissspidy Awaiting requested review from swissspidy

+1 more reviewer

@SirLouen SirLouen SirLouen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pbearne @SirLouen @westonruter @audrasjb @t-hamano